Github user chinmaykolhatkar commented on a diff in the pull request:

    
https://github.com/apache/incubator-apex-malhar/pull/207#discussion_r55667219
  
    --- Diff: 
library/src/test/java/com/datatorrent/lib/io/fs/FileSplitterInputTest.java ---
    @@ -110,8 +110,7 @@ protected void starting(org.junit.runner.Description 
description)
           fileSplitterInput.setIdempotentStorageManager(new 
IdempotentStorageManager.NoopIdempotentStorageManager());
     
           Attribute.AttributeMap.DefaultAttributeMap attributes = new 
Attribute.AttributeMap.DefaultAttributeMap();
    -      attributes.put(Context.DAGContext.APPLICATION_PATH,
    -          "target/" + className + "/" + methodName + "/" + 
Long.toHexString(System.currentTimeMillis()));
    +      attributes.put(Context.DAGContext.APPLICATION_PATH, "target/" + 
className + "/" + methodName + "/" + 
Long.toHexString(System.currentTimeMillis()));
    --- End diff --
    
    That's very wierd considering no code gets into master without rat check 
AFAIK.
     So without these changes does checkstyle validation fails?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to