[
https://issues.apache.org/jira/browse/APEXMALHAR-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15202809#comment-15202809
]
ASF GitHub Bot commented on APEXMALHAR-1897:
--------------------------------------------
Github user amberarrow commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/145#discussion_r56750393
--- Diff:
library/src/main/java/com/datatorrent/lib/state/BucketedState.java ---
@@ -29,11 +31,17 @@
public interface BucketedState
{
/**
+ * An expired value. In some implementations where bucketId is time
related then the event can be old and
+ * the get methods- getSync & getAsync return this special slice
instance.
+ */
+ Slice EXPIRED = new Slice(Ints.toByteArray(-1));
--- End diff --
Couldn't -1 be a valid user value ?
Might be better to use invalid slices, e.g. Slice(null, -1, -1). Or, if you
want to be more user friendly, extend Slice and add an isExpired() method which
checks offset and length against -1.
> Create ManagedState
> -------------------
>
> Key: APEXMALHAR-1897
> URL: https://issues.apache.org/jira/browse/APEXMALHAR-1897
> Project: Apache Apex Malhar
> Issue Type: Sub-task
> Reporter: Chandni Singh
> Assignee: Chandni Singh
> Fix For: 3.4.0
>
>
> ManagedState is described in the document below:
> https://docs.google.com/document/d/1gRWN9ufKSZSZD0N-pthlhpC9TZ8KwJ6hJlAX6nxl5f8/edit#heading=h.z87ti1fwyt0t
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
