[ 
https://issues.apache.org/jira/browse/APEXMALHAR-2025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15211326#comment-15211326
 ] 

ASF GitHub Bot commented on APEXMALHAR-2025:
--------------------------------------------

Github user chandnisingh commented on a diff in the pull request:

    
https://github.com/apache/incubator-apex-malhar/pull/220#discussion_r57414100
  
    --- Diff: 
library/src/main/java/com/datatorrent/lib/io/fs/LineByLineFileInputOperator.java
 ---
    @@ -0,0 +1,55 @@
    +package com.datatorrent.lib.io.fs;
    +
    +import java.io.BufferedReader;
    +import java.io.IOException;
    +import java.io.InputStream;
    +import java.io.InputStreamReader;
    +
    +import org.apache.hadoop.fs.Path;
    +
    +import com.datatorrent.api.DefaultOutputPort;
    +
    +/**
    + * This is an extension of the {@link AbstractFileInputOperator} that 
outputs the contents of a file line by line. 
    + * Each line is emitted as a separate tuple in string format.
    + * <p>
    + * The directory path where to scan and read files from should be 
specified using the {@link #directory} property.
    + * </p>
    + * @displayName File Line Input
    + * @category Input
    + * @tags fs, file, line, lines, input operator
    + */
    +public class LineByLineFileInputOperator extends 
AbstractFileInputOperator<String>
    --- End diff --
    
    The name is quite innovative :-) 
    Is the old name not ok?


> Move FileLineInputOperator out of AbstractFileInputOperator
> -----------------------------------------------------------
>
>                 Key: APEXMALHAR-2025
>                 URL: https://issues.apache.org/jira/browse/APEXMALHAR-2025
>             Project: Apache Apex Malhar
>          Issue Type: Improvement
>            Reporter: Chandni Singh
>            Assignee: Pramod Immaneni
>
> It is hard to find this operator and is used widely.
> Please put it in a file of its own.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to