[ 
https://issues.apache.org/jira/browse/APEXCORE-10?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15212785#comment-15212785
 ] 

ASF GitHub Bot commented on APEXCORE-10:
----------------------------------------

Github user tweise commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/250#discussion_r57509050
  
    --- Diff: engine/src/test/java/com/datatorrent/stram/AffinityRulesTest.java 
---
    @@ -0,0 +1,177 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package com.datatorrent.stram;
    +
    +import java.io.File;
    +import java.util.ArrayList;
    +import java.util.HashSet;
    +import java.util.List;
    +import java.util.Map;
    +import java.util.Set;
    +
    +import org.junit.Assert;
    +import org.junit.Test;
    +import org.apache.hadoop.yarn.api.records.NodeReport;
    +import org.apache.hadoop.yarn.api.records.NodeState;
    +import org.apache.hadoop.yarn.server.utils.BuilderUtils;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import com.google.common.collect.Lists;
    +import com.google.common.collect.Maps;
    +
    +import com.datatorrent.api.AffinityRule;
    +import com.datatorrent.api.AffinityRule.OperatorPair;
    +import com.datatorrent.api.AffinityRule.Type;
    +import com.datatorrent.api.AffinityRulesSet;
    +import com.datatorrent.api.Context.DAGContext;
    +import com.datatorrent.api.Context.OperatorContext;
    +import com.datatorrent.api.DAG.Locality;
    +import com.datatorrent.common.partitioner.StatelessPartitioner;
    +import com.datatorrent.stram.StreamingContainerAgent.ContainerStartRequest;
    +import com.datatorrent.stram.engine.GenericTestOperator;
    +import com.datatorrent.stram.engine.TestGeneratorInputOperator;
    +import com.datatorrent.stram.plan.logical.LogicalPlan;
    +import com.datatorrent.stram.plan.physical.PTContainer;
    +import com.datatorrent.stram.plan.physical.PTOperator;
    +import com.datatorrent.stram.support.StramTestSupport.MemoryStorageAgent;
    +
    +public class AffinityRulesTest
    +{
    +  private static final Logger LOG = 
LoggerFactory.getLogger(AffinityRulesTest.class);
    +
    +  @Test
    +  public void testOperatorPartitionsAntiAffinity()
    +  {
    +    LogicalPlan dag = new LogicalPlan();
    +    TestGeneratorInputOperator o1 = dag.addOperator("O1", new 
TestGeneratorInputOperator());
    +    GenericTestOperator o2 = dag.addOperator("O2", new 
GenericTestOperator());
    +    GenericTestOperator o3 = dag.addOperator("O3", new 
GenericTestOperator());
    +    dag.addStream("stream1", o1.outport, o2.inport1);
    +    dag.addStream("stream2", o2.outport1, o3.inport1);
    +
    +    dag.setAttribute(o2, OperatorContext.PARTITIONER, new 
StatelessPartitioner<GenericTestOperator>(5));
    +
    +    AffinityRulesSet ruleSet = new AffinityRulesSet();
    +    // Valid case:
    +    List<AffinityRule> rules = new ArrayList<>();
    +    ruleSet.setAffinityRules(rules);
    +    AffinityRule rule1 = new AffinityRule(Type.ANTI_AFFINITY, new 
OperatorPair("O2", "O2"), Locality.NODE_LOCAL, false);
    +    rules.add(rule1);
    +    dag.setAttribute(DAGContext.AFFINITY_RULES_SET, ruleSet);
    +    dag.validate();
    +    
dag.getAttributes().put(com.datatorrent.api.Context.DAGContext.APPLICATION_PATH,
 new File("target", HostLocalTest.class.getName()).getAbsolutePath());
    --- End diff --
    
    see StramTestSupport.TestMeta


> Enable non-affinity of operators per node (not containers)
> ----------------------------------------------------------
>
>                 Key: APEXCORE-10
>                 URL: https://issues.apache.org/jira/browse/APEXCORE-10
>             Project: Apache Apex Core
>          Issue Type: Task
>            Reporter: Amol Kekre
>            Assignee: Isha Arkatkar
>              Labels: roadmap
>
> The issue happens on cloud which provides virtual cores with software like 
> Xen underneath. In effect if CPU intensive operators land up on same node we 
> have a resource bottleneck,
> Need to create an attribute that does the following
> - Operators A & B should not be on same node
> - Stram should use this attribute to try to get containers on different node
> It is understood that the user is making an explicit choice to use NIC 
> instead of stream local optimization



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to