[
https://issues.apache.org/jira/browse/APEXCORE-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15225611#comment-15225611
]
ASF GitHub Bot commented on APEXCORE-411:
-----------------------------------------
Github user tweise commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/294#discussion_r58482768
--- Diff: engine/src/main/java/com/datatorrent/stram/cli/DTCli.java ---
@@ -1861,49 +1862,60 @@ public void execute(String[] args, ConsoleReader
reader) throws Exception
} catch (Exception ex) {
throw new CliException("Error opening the config XML file: " +
configFile, ex);
}
- String fileName = expandFileName(commandLineInfo.args[0], true);
StramAppLauncher submitApp;
AppFactory appFactory = null;
- String matchString = commandLineInfo.args.length >= 2 ?
commandLineInfo.args[1] : null;
- if (fileName.endsWith(".json")) {
- File file = new File(fileName);
- submitApp = new StramAppLauncher(file.getName(), config);
- appFactory = new StramAppLauncher.JsonFileAppFactory(file);
- if (matchString != null) {
- LOG.warn("Match string \"{}\" is ignored for launching
applications specified in JSON", matchString);
- }
- } else if (fileName.endsWith(".properties")) {
- File file = new File(fileName);
- submitApp = new StramAppLauncher(file.getName(), config);
- appFactory = new StramAppLauncher.PropertyFileAppFactory(file);
- if (matchString != null) {
- LOG.warn("Match string \"{}\" is ignored for launching
applications specified in properties file", matchString);
+ String matchString = null;
+ if (commandLineInfo.args.length == 0) {
+ if (commandLineInfo.origAppId == null) {
+ throw new CliException("APA or JAR file is required for
launching an application when not recovering from a terminated application");
--- End diff --
"when not resuming terminated application" ?
> Restart app without specifying app package
> ------------------------------------------
>
> Key: APEXCORE-411
> URL: https://issues.apache.org/jira/browse/APEXCORE-411
> Project: Apache Apex Core
> Issue Type: New Feature
> Reporter: David Yan
> Assignee: David Yan
>
> In the CLI, the launch command with -originalAppId requires the specification
> of the app package. This should be made optional because the app directory
> of the original app already contains the jar files necessary to restart the
> app.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
