[
https://issues.apache.org/jira/browse/APEXCORE-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15258808#comment-15258808
]
ASF GitHub Bot commented on APEXCORE-107:
-----------------------------------------
Github user tushargosavi commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/313#discussion_r61153475
--- Diff: api/src/main/java/com/datatorrent/api/Module.java ---
@@ -36,7 +36,7 @@
* @since 3.3.0
*/
@InterfaceStability.Evolving
-public interface Module
+public interface Module extends Operator
--- End diff --
The difference design could be having a common interface, which is shared
by all type of Nodes in the DAG. Have updated the pull request with this
approach.
> Support adding module to application using property file API.
> -------------------------------------------------------------
>
> Key: APEXCORE-107
> URL: https://issues.apache.org/jira/browse/APEXCORE-107
> Project: Apache Apex Core
> Issue Type: Task
> Reporter: Tushar Gosavi
> Assignee: Tushar Gosavi
>
> Add support for adding modules in the DAG specified through property file and
> json file. The sample json format is specified below.
> {code}
> {
> "operators": [
> {
> "name": "operator1",
> "class": "com.datatorrent.lib.operator.Input",
> "properties": {
> "property1": "value1"
> }
> },
> {
> "name": "module1",
> "class": "com.datatorrent.module.Module1",
> "properties": {
> "property1": "value1"
> }
> },
> ],
> "streams": [
> {
> "name": "s1",
> "source": {
> "operatorName": "operator1",
> "portName": "output"
> },
> "sinks": [
> {
> "operatorName": "module",
> "portName": "input"
> }
> ]
> }
> ]
> }
> {code}
> For this to work, we will need to support adding module in DAG through
> property file API.
> This will allow external tools to visually construct the DAG containing
> modules.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
