[
https://issues.apache.org/jira/browse/APEXMALHAR-2068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15264981#comment-15264981
]
ASF GitHub Bot commented on APEXMALHAR-2068:
--------------------------------------------
Github user chandnisingh commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/259#discussion_r61659396
--- Diff:
library/src/main/java/com/datatorrent/lib/io/fs/FileSplitterInput.java ---
@@ -96,7 +96,7 @@ public FileSplitterInput()
{
super();
currentWindowRecoveryState = Lists.newLinkedList();
- idempotentStorageManager = new
IdempotentStorageManager.FSIdempotentStorageManager();
+ idempotentStorageManager = new
IdempotentStorageManager.NoopIdempotentStorageManager();
--- End diff --
The reason to make this change is that if multiple
```FSIdempotentStorageManager```s are used in an application then their state
(on disk) collide. The jira APEXMALHAR-2068 is opened to address that.
The problem in having FSIdempotentStorageManager as default is that the
users get bewildered because of in-correct behavior manifested by the bug
mentioned above.
If the user sets FSIdempotentStorageManage explicitly then they can ensure
to make the relative path unique as well.
Not setting any default entails additional step of setting an Idempotent
storage manager even when the user doesn't care about idempotency.
> FileSplitter- having multiple file splitters in an application results in
> incorrect behavior
> --------------------------------------------------------------------------------------------
>
> Key: APEXMALHAR-2068
> URL: https://issues.apache.org/jira/browse/APEXMALHAR-2068
> Project: Apache Apex Malhar
> Issue Type: Bug
> Reporter: Chandni Singh
> Assignee: Chandni Singh
>
> If an application has multiple logical operators that use Window Data
> Manager, then by default they share the same state. This is confusing and
> cause issues.
> We need to make this path unique by default for each logical instance.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
