[jira] [Commented] (APEXMALHAR-1953) Add generic (insert, update, delete) support to JDBC Output Operator

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/APEXMALHAR-1953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15279693#comment-15279693
 ] 

ASF GitHub Bot commented on APEXMALHAR-1953:
--------------------------------------------

Github user bhupeshchawda commented on a diff in the pull request:

    
https://github.com/apache/incubator-apex-malhar/pull/215#discussion_r62801341
  
    --- Diff: 
library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPOJOOutputOperator.java
 ---
    @@ -63,22 +58,18 @@
      * @since 2.1.0
      */
     @org.apache.hadoop.classification.InterfaceStability.Evolving
    -public class JdbcPOJOOutputOperator extends 
AbstractJdbcTransactionableOutputOperator<Object>
    -    implements Operator.ActivationListener<OperatorContext>
    +public abstract class AbstractJdbcPOJOOutputOperator extends 
AbstractJdbcTransactionableOutputOperator<Object>
     {
    -  @NotNull
    -  private List<FieldInfo> fieldInfos;
    +  private List<JdbcFieldInfo> fieldInfos;
    --- End diff --
    
    We can call it SqlFieldInfo.
    I think JdbcFieldInfo is also appropriate right? 


> Add generic (insert, update, delete) support to JDBC Output Operator
> --------------------------------------------------------------------
>
>                 Key: APEXMALHAR-1953
>                 URL: https://issues.apache.org/jira/browse/APEXMALHAR-1953
>             Project: Apache Apex Malhar
>          Issue Type: Task
>            Reporter: Bhupesh Chawda
>            Assignee: Bhupesh Chawda
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)