[
https://issues.apache.org/jira/browse/APEXMALHAR-2077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15286587#comment-15286587
]
ASF GitHub Bot commented on APEXMALHAR-2077:
--------------------------------------------
Github user yogidevendra commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/273#discussion_r63518655
--- Diff:
library/src/main/java/com/datatorrent/lib/io/fs/AbstractSingleFileOutputOperator.java
---
@@ -39,10 +43,42 @@
@NotNull
protected String outputFileName;
+ /**
+ * partitionedFileName string format specifier
+ e.g. fileName_physicalPartionId -> %s_%d
+ */
+ private String partitionedFileNameformat = "%s_%d";
+
+ /**
+ * Derived name for file based on physicalPartitionId
+ */
+ private transient String partitionedFileName;
+
+ /**
+ * Physical partition id for the current partition.
+ */
+ private transient int physicalPartitionId;
+
+ /**
+ * Initializing current partition id, partitionedFileName etc.
{@inheritDoc}
+ */
+ @Override
+ public void setup(OperatorContext context)
+ {
+ super.setup(context);
+ physicalPartitionId = context.getId();
+ if(StringUtils.isEmpty(partitionedFileNameformat)){
+ partitionedFileName = outputFileName;
+ }
+ else{
--- End diff --
Good catch. I will fix this. But, just wondering why checkstyle did not
catched this?
Anything else?
> SingleFileOutputOperator should append partitionId to file name
> ---------------------------------------------------------------
>
> Key: APEXMALHAR-2077
> URL: https://issues.apache.org/jira/browse/APEXMALHAR-2077
> Project: Apache Apex Malhar
> Issue Type: Improvement
> Reporter: Yogi Devendra
> Assignee: Yogi Devendra
> Priority: Minor
> Fix For: 3.4.0
>
>
> If SingleFileOutputOperator is partitioned into more than one physical
> instances then it should append partitionId to file name. So that, each
> partition can independently write to separate file.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
