Send a PR after several conversations in an issue is pretty clear & good :)
Ming Wen <[email protected]> 于 2019年10月26日周六 10:19写道： > thanks, zhiyuan. > Apache APISIX has a simple guidance[1] for PR and commit message now, but I > think conventionalcommits is better, > especially it can be generated changelog automatically. > > [1] > > https://github.com/iresty/apisix/blob/master/Contributing.md#how-to-add-a-new-feature-or-change-an-existing-one > > Thanks, > Ming Wen, Apache APISIX > Twitter: _WenMing > > > Zhiyuan Ju <[email protected]> 于2019年10月26日周六 上午9:45写道： > > > Hi, > > > > I'm glad to *share* a site[1][2], which contains some specifications > about > > Git commit messages. > > > > Happy to be that we use a squash based workflow as this link says[3], and > > only collaborators have access to Squash & Merge PR into the master > branch. > > > > [1] Chinese Version > > https://www.conventionalcommits.org/zh-cn/v1.0.0-beta.4/ > > [2] English Version https://www.conventionalcommits.org/en/v1.0.0/ > > [3] > > > > > https://www.conventionalcommits.org/en/v1.0.0/#do-all-my-contributors-need-to-use-the-conventional-commit-specification > > > > Best Regards! > > @ Zhiyuan Ju <https://www.shaoyaoju.org/> > > >
