Hi Justin and Ming, > notice several 3rd party logos are included in the release, are they > being used correctly and correct attribution been given to them?
Just for sure, those 3rd party logos are under the /dashboard folder? like the attachment favicon-16x16.png? These logo files are displayed in Dashboard :) Also I noticed that Zipkin also has the logo file in its release. > These files are from the compiled dashboard code. > I think that APISIX can no longer contain compiled dashboard code, but > instead guides the user to compile the dashboard from source, > and it will solve the license problem. I will provide detailed build steps if needed. Best Regards! @ Zhiyuan Ju <https://www.shaoyaoju.org/> Justin Mclean <[email protected]> 于2019年11月12日周二 下午5:29写道： > Hi, > > > These files are from the compiled dashboard code. > > I think that APISIX can no longer contain compiled dashboard code, but > > instead guides the user to compile the dashboard from source, > > and it will solve the license problem. > > That's a solution, but then you would need to release it as well, either > as a seperate release or part of this release. I’m not sure what would be > more effort. > > > That is an old version, I forgot to modify this file, thank you for > > reminding me. am going to update to the version of apache. > > I’d just provide a link to the apache one, that way there no need to > update anything if it changes. Not a major issues. > > > Can you give a few examples of these logos? I will confirm for them. > > Zipkin was one of them, but there's at least 1/2 dozen others. Just run > rat on the release and grep for binary files (“ B “) and the names will > show up. Also something that doesn’t need to be solved right away. > > Thanks, > Justin
