On Fri, Jan 3, 2020 at 5:54 PM Li Ling(Lien) <lil...@apache.org> wrote:
> I think a websocket enable feature here can be also good. > Of course, we can support it. > > junxu chen <chenju...@apache.org> 于2020年1月3日周五 下午5:40写道： > > > > > > > > curl -i http://127.0.0.1:9080/apisix/admin/services/1 -X PUT -d ' > > > { > > > "upstream": { > > > "path": "/index.html", > > > "host": "foo.com", > > > "scheme": "http", > > > "type": "roundrobin", > > > "nodes": { > > > "39.97.63.215:80 <http://39.97.63.215/>": 1 > > > } > > > } > > > }' > > > > > > > is better > > > > On Thu, Jan 2, 2020 at 6:04 PM Ming Wen <wenm...@apache.org> wrote: > > > > > looks good to me. > > > > > > Thanks, > > > Ming Wen, Apache APISIX > > > Twitter: _WenMing > > > > > > > > > YuanSheng Wang <membp...@gmail.com> 于2020年1月2日周四 下午5:58写道： > > > > > > > curl -i http://127.0.0.1:9080/apisix/admin/services/1 -X PUT -d ' > > > > { > > > > "upstream": { > > > > "path": "/index.html", > > > > "host": "foo.com", > > > > "scheme": "http", > > > > "type": "roundrobin", > > > > "nodes": { > > > > "39.97.63.215:80": 1 > > > > } > > > > } > > > > }' > > > > > > > > How about we put them in the `upstream` object? > > > > > > > > On Thu, Jan 2, 2020 at 4:06 PM YuanSheng Wang <membp...@gmail.com> > > > wrote: > > > > > > > > > > This implementation will replace some features of the > `proxy-rewrite` > > > > > plugin, > > > > > > > > > > Yes > > > > > > > > > > > The `up_*` naming is hard to understand. > > > > > > > > > > Any good name style? > > > > > > > > > > > > > > > On Thu, Jan 2, 2020 at 3:27 PM Ming Wen <wenm...@apache.org> > wrote: > > > > > > > > > >> This implementation will replace some features of the > `proxy-rewrite` > > > > >> plugin, > > > > >> right? > > > > >> BTW, the `up_*` naming is hard to understand. > > > > >> > > > > >> Thanks, > > > > >> Ming Wen, Apache APISIX > > > > >> Twitter: _WenMing > > > > >> > > > > >> > > > > >> YuanSheng Wang <membp...@gmail.com> 于2020年1月2日周四 下午2:53写道： > > > > >> > > > > >> > Hi: > > > > >> > > > > > >> > Supports more upstream parameters in `service`, this will make > > > APISIX > > > > >> > easier to use. > > > > >> > > > > > >> > What do you think? > > > > >> > > > > > >> > For example: up_path, up_host, up_port or up_scheme. > > > > >> > > > > > >> > curl -i http://127.0.0.1:9080/apisix/admin/services/1 -X PUT > -d ' > > > > >> > { > > > > >> > "upstream": { > > > > >> > "type": "roundrobin", > > > > >> > "nodes": { > > > > >> > "39.97.63.215:80": 1 > > > > >> > } > > > > >> > }, > > > > >> > "up_path": "/index.html", > > > > >> > "up_host": "foo.com", > > > > >> > "up_scheme": "http" > > > > >> > }' > > > > >> > > > > > >> > curl -i http://127.0.0.1:9080/apisix/admin/services/1 -X PUT > -d ' > > > > >> > { > > > > >> > "upstream": { > > > > >> > "type": "roundrobin", > > > > >> > "nodes": { > > > > >> > "39.97.63.215:80": 1 > > > > >> > } > > > > >> > }, > > > > >> > "up_host": "foo.com", > > > > >> > "up_scheme": "https" > > > > >> > }' > > > > >> > > > > > >> > -- > > > > >> > > > > > >> > *MembPhis* > > > > >> > My github: https://github.com/membphis > > > > >> > Apache APISIX: https://github.com/apache/incubator-apisix > > > > >> > > > > > >> > > > > > > > > > > > > > > > -- > > > > > > > > > > *MembPhis* > > > > > My github: https://github.com/membphis > > > > > Apache APISIX: https://github.com/apache/incubator-apisix > > > > > > > > > > > > > > > > > -- > > > > > > > > *MembPhis* > > > > My github: https://github.com/membphis > > > > Apache APISIX: https://github.com/apache/incubator-apisix > > > > > > > > -- *MembPhis* My github: https://github.com/membphis Apache APISIX: https://github.com/apache/incubator-apisix
