Hi, yuansheng, I guess the link[1] in your first email is misleading. I think your original intention was to add a driver to parse the GeoIP2 library, and it will not add a binary GeoIP2 database to the repo, right?
Back to Justin's question, GeoIP2 also provides the geolite2 version[2], which is under the Creative Commons Attribution-Share Alike 4.0 license. So if Apache APISIX wants to support GeoIP2, We need to clearly indicate its geoip2 and geolite2 version in the document. [1] https://www.maxmind.com/en/geoip2-databases [2] https://dev.maxmind.com/geoip/geoip2/geolite2/ Thanks, Ming Wen, Apache APISIX Twitter: _WenMing YuanSheng Wang <[email protected]> 于2020年1月7日周二 上午9:59写道： > > Perhaps / perhaps not - it will depend on how this is done and how the > user is informed. > > 1. this is an optional feature. > 2. only some users need to enable this feature. > 3. add more documents about how to enable this feature. > > BTW, I searched the projects in Apache, the `GeoIP2` library has been used > to many projects of Apache [1]. > > [1] https://github.com/search?q=org%3Aapache+MaxMind&type=Code > > On Tue, Jan 7, 2020 at 3:26 AM Justin Mclean <[email protected]> > wrote: > > > Hi, > > > > > We only provide GeoIP2 driver code, APISIX users should fetch the IP > > > database by himself if they want to enable the IP location feature. > > > > > > So I think that is fine for the license. > > > > Perhaps / perhaps not - it will depend on how this is done and how the > > user is informed. [1] > > > > Thanks, > > Justin > > > > 1. https://www.apache.org/legal/resolved.html#optional > > > > -- > > *MembPhis* > My github: https://github.com/membphis > Apache APISIX: https://github.com/apache/incubator-apisix >
