+1 approve I just checked:
- [√] Download links are valid. - [√] Checksums and PGP signature are valid. - [√] DISCLAIMER file is included. - [√] Both LICENSE and NOTICE files are good. - [√] No binary file. - [√] All files have valid License header if necessary. - [√] Dashboard and its sub pages can be access without error code Zhiyuan Ju <juzhiy...@apache.org> 于2020年1月22日周三 上午10:55写道： > Hi Justin, > > Thank you for your check :) > > I just updated the KEYS file, so could you please download the latest > version and try again? btw, the NOTICE file on v1.0 branch has been > updated. > > Also, *node-notifier *module has been removed from *dev dependencies*, the > other one *throttle-debounce* will be kept for > *vue-typescript-admin-docs *boilerplate. > I'm not sure if we could use these dependencies for development > environment. > > Best Regards! > @ Zhiyuan Ju <https://www.shaoyaoju.org/> > > > Justin Mclean <jus...@classsoftware.com> 于2020年1月22日周三 上午7:13写道： > > > Hi, > > > > -1 (binding) no public key and key not in [1] (Note this is easily fixed > > and there’s no need to cancel the vote) > > > > I checked: > > - incubating in name > > - signature not able to be verified, hash fine > > - DISCLAIMER exists > > - LICENSE is fine > > - NOTICE has wrong year > > - All source files have ASF headers > > - No unexpected binary files > > - can compile from source > > > > After compiling there seem to be a couple of Category X files downloaded > > [2], can you confirm these are not required dependancies. > > > > Thanks, > > Justin > > > > > > 1. https://dist.apache.org/repos/dist/dev/incubator/apisix/KEYS > > 2. ./node_modules/node-notifier/vendor/snoreToast/LICENSE > > 3. ./node_modules/throttle-debounce/LICENSE.md > > > > > > >
