> is there any queue mechanism in LUA? https://github.com/openresty/lua-nginx-module#ngxshareddictlpush https://github.com/openresty/lua-nginx-module#ngxshareddictrpop
We can use this method which is simple. On Wed, Feb 19, 2020 at 11:27 PM Sheng Wu <[email protected]> wrote: > Hi > > I am wondering, is there any queue mechanism in LUA? > The scenario is, SkyWalking filter needs to manipulate header and generate > spans. > But the span should be sent in the async mode(not blocking the original > request) for better performance. I notice there is the Coroutine mechanism, > is this suitable for this? > > Sheng Wu 吴晟 > Twitter, wusheng1108 > > > Ming Wen <[email protected]> 于2020年2月19日周三 下午6:14写道： > > > > Currently, I want to use skywalking-nginx-lua repo to host the codes. > > WDYT? > > > > looks good to me. > > > > > We haven't, but I think that is not so hard. About gRPC and HTTP, what > do > > > you prefer? Or is there a gRPC-LUA lib? We are considering > > Jetty+REST/JSON or gRPC-web. > > > > From the perspective of nginx-lua, HTTP will be easier to implement > because > > nginx-lua does not yet have http2 and grpc client libraries :( > > Nginx-lua only supports grpc proxy now. > > > > Thanks, > > Ming Wen, Apache APISIX > > Twitter: _WenMing > > > > > > Sheng Wu <[email protected]> 于2020年2月19日周三 下午4:57写道： > > > > > HI Ming Wen > > > > > > I am/was a member of OpenTracing core team, but the status of that OSS > > > community is not good. > > > I don't want any direct link, especially API level dependency on that. > > > > > > Currently, I want to use skywalking-nginx-lua repo to host the codes. > > WDYT? > > > > > > > Is there a draft implementation already? The skywalking-nginx-lua > will > > be > > > > implemented by HTTP not gRPC, right? > > > > > > We haven't, but I think that is not so hard. About gRPC and HTTP, what > do > > > you prefer? Or is there a gRPC-LUA lib? We are considering > > Jetty+REST/JSON > > > or gRPC-web. > > > > > > Sheng Wu 吴晟 > > > Twitter, wusheng1108 > > > > > > > > > Ming Wen <[email protected]> 于2020年2月19日周三 下午1:58写道： > > > > > > > Hi, Sheng Wu, > > > > That's really good news for me. > > > > > > > > Apache APISIX has a Zipkin plugin[1] based on > opentracing-openresty[2], > > > but > > > > not good enough for SkyWalking. > > > > > > > > IMO, we can implement skywalking-nginx-lua in a separate repo first > > using > > > > opentracing-openresty[2], then add skywalking plugin in APISIX. > > > > > > > > Is there a draft implementation already? The skywalking-nginx-lua > will > > be > > > > implemented by HTTP not gRPC, right? > > > > > > > > [1] > > > > > > > > > > > > > > https://github.com/apache/incubator-apisix/blob/master/lua/apisix/plugins/zipkin.lua > > > > [2] https://github.com/iresty/opentracing-openresty > > > > > > > > Thanks, > > > > Ming Wen, Apache APISIX > > > > Twitter: _WenMing > > > > > > > > > > > > Sheng Wu <[email protected]> 于2020年2月19日周三 上午10:53写道： > > > > > > > > > Forward to SkyWalking dev. > > > > > FYI. > > > > > > > > > > Sheng Wu 吴晟 > > > > > Twitter, wusheng1108 > > > > > > > > > > > > > > > Sheng Wu <[email protected]> 于2020年2月19日周三 上午10:43写道： > > > > > > > > > > > Hi APISIX dev team > > > > > > > > > > > > I am Sheng Wu, from SkyWalking PMC team. > > > > > > Right now, I am investing the possibility of providing native > > agents > > > in > > > > > > different languages(maybe) for the proxy solution, such as > > > Envoy-WASM, > > > > > > APISIX/Nginx. > > > > > > > > > > > > As APISIX is the native extension of Nginx, I hope I could get > some > > > > ideas > > > > > > from you. > > > > > > I noticed there is a Zipkin implementation or OpenTracing one? > But > > > > sadly, > > > > > > either of them are not good enough for SkyWalking backend to fit > > the > > > > APM > > > > > > field, we need to do more. > > > > > > > > > > > > Could you give me some guides about where should I start? Are the > > > APIs > > > > > > related to APISIX directly or I should use Nginx LUA API? > > > > > > And where should I host these new codes? Should I release on > > > > > > skywalking-apisix-lua(for example) or inside the apisix repo. > > > > > > > > > > > > Sheng Wu 吴晟 > > > > > > Twitter, wusheng1108 > > > > > > > > > > > > > > > > > > > > > -- *MembPhis* My github: https://github.com/membphis Apache APISIX: https://github.com/apache/incubator-apisix
