+1 I checked: - download links are valid - signatures and hashes fine - DISCLAIMER exists - LICENSE and NOTICE good - no binary files - all source file have ASF headers - compiled and ran quick start on macOS
On Mon, Apr 13, 2020 at 2:53 PM Nirojan Selvanathan <sshn...@gmail.com> wrote: > +1, > > Checked the download links and keys. > > On Mon, Apr 13, 2020 at 5:44 AM YuanSheng Wang <membp...@apache.org> > wrote: > > > +1 > > > > I checked: > > - Download links are valid. > > - Checksums and PGP signatures are valid. > > - DISCLAIMER is included. > > - LICENSE and NOTICE files are good. > > - No binary file. > > - All files have license headers if necessary. > > - fedora 31: run `make deps`, install success. and it works fine at my > VM, > > and the version is '1.2'. > > > > > > > > On Mon, Apr 13, 2020 at 10:13 AM 88786...@qq.com <88786...@qq.com> > wrote: > > > > > +1 > > > > > > > > > > > > 88786...@qq.com > > > > > > From: Justin Mclean > > > Date: 2020-04-13 10:12 > > > To: dev > > > Subject: Re: [VOTE] Release Apache APISIX (Incubating) 1.2-RC1 > > > Hi, > > > > > > +1 (binding) > > > > > > I checked: > > > - incubating in name > > > - signatures and hash fine > > > - DISCLAIMER exists > > > - LICENSE and NOTICE all good > > > - All source files have ASF headers > > > - No unexpected binary files > > > - I didn’t;t compile form source (environment not set up) > > > > > > Thanks, > > > Justin > > > > > > > > > -- > > *MembPhis* > > My github: https://github.com/membphis > > Apache APISIX: https://github.com/apache/incubator-apisix > > > > > -- > Best Regards, > S.Nirojan > > Research Engineer > Linked-in: https://www.linkedin.com/in/niroselva/ > Mobile : (+94) 779823445 / 067763149095 >