+1

I checked:
- incubating in name
- download links are valid
- signatures and hashes fine
- DISCLAIMER is included
- LICENSE and NOTICE good
- no binary files
- all source file have ASF headers
- compiled and ran quick start on CentOS 7

I found the folder `dashboard` is empty.

jinwei <gxt...@163.com> 于2020年6月21日周日 下午12:25写道:

>
> +1
>
>
>
>
>
>
>
> At 2020-06-21 12:02:45, "孙毅" <su...@apache.org> wrote:
> >+1
> >
> >agile6v <agil...@apache.org> 于2020年6月21日周日 上午10:52写道:
> >
> >> +1
> >>
> >> I checked:
> >>
> >> [x] Incubating in name
> >> [x] Download links are valid.
> >> [x] Checksums and PGP signatures are valid.
> >> [x] The DISCLAIMER is included.
> >> [x] Both LICENSE and NOTICE files are good.
> >> [x] No binary file.
> >> [x] All files have license headers if necessary.
> >>
> >> On 2020/06/20 12:21:13, Nirojan Selvanathan <sshn...@gmail.com> wrote:
> >> > Hello, Community,
> >> >
> >> > This is a call for the vote to release Apache APISIX (Incubating)
> >> > version 1.4-RC1.
> >> >
> >> >
> >> > Release notes:
> >> > https://github.com/apache/incubator-apisix/blob/v1.4/CHANGELOG.md#140
> >> >
> >> >
> >> > The release candidates:
> >> > https://dist.apache.org/repos/dist/dev/incubator/apisix/1.4-rc1/
> >> >
> >> >
> >> > Git tag for the release:
> >> > https://github.com/apache/incubator-apisix/tree/v1.4
> >> >
> >> >
> >> > Release Commit ID:
> >> >
> >> https://github.com/apache/incubator-apisix/commit/f7584f680697179f5af44dbff5e26ad25cb860e8
> >> >
> >> >
> >> > Keys to verify the Release Candidate:
> >> > https://dist.apache.org/repos/dist/dev/incubator/apisix/KEYS
> >> >
> >> >
> >> > Steps to validating the release:
> >> >
> >> > 1. Download the release
> >> > ```
> >> > wget
> >> > https://dist.apache.org/repos/dist/dev/incubator/apisix/1.4-rc1/apache
> >> > -apisix-1.4-rc1-incubating-src.tar.gz
> >> > ```
> >> >
> >> >
> >> > 2. Checksums and signatures
> >> > ```
> >> > wget https://dist.apache.org/repos/dist/dev/incubator/apisix/KEYS
> >> > wget
> >> > https://dist.apache.org/repos/dist/dev/incubator/apisix/1.4-rc1/apache
> >> > -apisix-1.4-rc1-incubating-src.tar.gz.asc
> >> > wget
> >> > https://dist.apache.org/repos/dist/dev/incubator/apisix/1.4-rc1/apache
> >> > -apisix-1.4-rc1-incubating-src.tar.gz.sha512
> >> >
> >> > shasum -c apache-apisix-1.4-rc1-incubating-src.tar.gz.sha512
> >> > gpg --import KEYS
> >> >
> >> > # input `trust`, `5`, then `save`
> >> >
> >> > gpg --edit-key "Nirojan Selvanathan"
> >> > gpg --verify apache-apisix-1.4-rc1-incubating-src.tar.gz.asc
> >> > apache-apisix-1.4-rc1-incubating-src.tar.gz
> >> > ```
> >> >
> >> > 3. Unzip and Check files
> >> > ```
> >> > tar zxvf apache-apisix-1.4-rc1-incubating-src.tar.gz
> >> > ```
> >> >
> >> > 4. This release contains the dashboard code for APISIX
> >> >
> >> https://github.com/apache/incubator-apisix-dashboard/tree/329b092dcaa7a505dcdec86c667b6803f5863d94
> >> >
> >> >
> >> > 5. Build Apache APISIX:
> >> > https://github.com/apache/incubator-apisix/blob/v1.4/doc/how-to-build.md
> >> >
> >> >
> >> > The vote will be open for at least 72 hours or until the necessary number
> >> > of votes is reached.
> >> >
> >> > Please vote accordingly:
> >> > [ ] +1 approve
> >> >
> >> > [ ] +0 no opinion
> >> >
> >> > [ ] -1 disapprove with the reason
> >> >
> >> >
> >> > Checklist for reference:
> >> > [ ] Download links are valid.
> >> >
> >> > [ ] Checksums and PGP signatures are valid.
> >> >
> >> > [ ] DISCLAIMER is included.
> >> >
> >> > [ ] LICENSE and NOTICE files are good.
> >> >
> >> > [ ] No binary file.
> >> >
> >> > [ ] All files have license headers if necessary.
> >> >
> >> > And below is a more detailed checklist:
> >> > https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release
> >> > +Checklist
> >> >
> >> > --
> >> > Best Regards,
> >> > S.Nirojan
> >> > Linked-in <https://www.linkedin.com/in/niroselva/>
> >> >
> >>

Reply via email to