+1 binding
I checked:
- Download links are valid
- Checksums and signatures are fine
- Binary file: docs/images/*.png, and confirmed they are fine(No
copyright issues)
- command: find . -exec file {} \; | grep -v "ASCII" | grep -v
"directory" | grep -v "PEM" | grep -v "UTF-8"
- All files have valid header
- LICENSE & NOTICE files are good
- Build Docker image on OSX successfully
# /tmp/ingress/apache-apisix-ingress-controller-0.1.0 [14:44:50]
$ docker build -t apache/ingress-controller:v0.1.0 .
...
---> Running in 4bc2d440c15c
Removing intermediate container 4bc2d440c15c
---> 73587b149736
Successfully built 73587b149736
Successfully tagged apache/ingress-controller:v0.1.0
wei jin <[email protected]> 于2020年12月22日周二 下午2:29写道：
> +1 binding
>
> I checked:
>
> - Download links are valid
> - Checksums and signatures are fine
> - Binary file: docs/images/*.png, and confirmed they are fine(No
> copyright issues)
> - command: find . -exec file {} \; | grep -v "ASCII" | grep -v
> "directory" | grep -v "PEM" | grep -v "UTF-8"
> - All files have valid header
> - LICENSE & NOTICE files are good
> - Build successfully on centos 7 and mac os
> - Build Docker image successfully
> - Deploy and work in ACK and azure cloud successfully
>
> YuanSheng Wang <[email protected]> 于2020年12月22日周二 下午2:06写道：
>
> > +1 binding
> >
> > checked list:
> >
> > - Download links are valid
> > - Checksums and signatures are fine
> > - Binary file: docs/images/*.png, and confirmed they are fine(No
> > copyright issues)
> > - command: find . -exec file {} \; | grep -v "ASCII" | grep -v
> > "directory" | grep -v "PEM" | grep -v "UTF-8"
> > - License header: fine
> > - LICENSE & NOTICE files are good
> >
> >
> > ```
> > $ make license-check
> > .actions/openwhisk-utilities/scancode/scanCode.py --config
> > .actions/ASF-Release.cfg ./
> > Reading configuration file [.actions/ASF-Release.cfg]...
> > Scanning files starting at [./]...
> > All checks passed.
> >
> > $ find . -exec file {} \; | grep -v "ASCII" | grep -v "directory" | grep
> > -v "PEM" | grep -v "UTF-8"
> > ./docs/images/module.png: PNG image data, 1540 x 914, 8-bit/color RGBA,
> > non-interlaced
> > ./docs/images/scene.png: PNG image data, 2248 x 1008, 8-bit/color RGBA,
> > non-interlaced
> > ./docs/images/first.png: PNG image data, 2188 x 692, 8-bit/color RGBA,
> > non-interlaced
> > ./docs/images/struct-compare.png: PNG image data, 1162 x 850, 8-bit/color
> > RGB, non-interlaced
> > ./docs/images/module-1.png: PNG image data, 916 x 586, 8-bit/color RGBA,
> > non-interlaced
> > ./docs/images/module-0.png: PNG image data, 1268 x 658, 8-bit/color RGBA,
> > non-interlaced
> > ./docs/images/flow.png: PNG image data, 1538 x 1344, 8-bit/color RGBA,
> > non-interlaced
> > ./docs/images/hierarchical.png: PNG image data, 796 x 600, 8-bit/color
> > RGBA, non-interlaced
> > ./docs/images/diff-flow.png: PNG image data, 2202 x 568, 8-bit/color
> RGBA,
> > non-interlaced
> >
> >
> > On Fri, Dec 18, 2020 at 7:52 PM wei jin <[email protected]> wrote:
> >
> > > Hello, Community,
> > >
> > > This is a call for the vote to release Apache apisix-ingress-controller
> > > version 0.1.0 .
> > >
> > > Release notes:
> > >
> > >
> > >
> >
> https://github.com/apache/apisix-ingress-controller/blob/v0.1.0/CHANGELOG.md
> > >
> > > The release candidates:
> > >
> > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/apisix/apisix-ingress-controller-0.1.0-rc2/
> > >
> > > Git tag for the release:
> > >
> > > https://github.com/apache/apisix-ingress-controller/tree/v0.1.0
> > >
> > > Release Commit ID:
> > >
> > >
> > >
> >
> https://github.com/apache/apisix-ingress-controller/commit/ecd479ad1ef50d94b3731d0ffbcdf6dd0f3ef19b
> > >
> > > Keys to verify the Release Candidate:
> > >
> > > https://dist.apache.org/repos/dist/dev/apisix/KEYS
> > >
> > > Steps to validate the release:
> > >
> > > 1.Download the release file
> > >
> > > ```sh
> > > $ wget
> > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/apisix/apisix-ingress-controller-0.1.0-rc2/apache-apisix-ingress-controller-0.1.0-rc2-src.tar.gz
> > > ```
> > >
> > > 2.Checksums and signatures:
> > >
> > > ```sh
> > > $ wget https://dist.apache.org/repos/dist/dev/apisix/KEYS
> > >
> > > $ wget
> > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/apisix/apisix-ingress-controller-0.1.0-rc2/apache-apisix-ingress-controller-0.1.0-rc2-src.tar.gz.asc
> > >
> > > $ wget
> > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/apisix/apisix-ingress-controller-0.1.0-rc2/apache-apisix-ingress-controller-0.1.0-rc2-src.tar.gz.sha512
> > >
> > > $ shasum -c
> apache-apisix-ingress-controller-0.1.0-rc2-src.tar.gz.sha512
> > >
> > > $ gpg --import KEYS
> > >
> > > # Input "trust", then input number 5, then input "save"
> > > $ gpg --edit-key "Wei Jin"
> > >
> > > $ gpg --verify
> apache-apisix-ingress-controller-0.1.0-rc2-src.tar.gz.asc
> > > apache-apisix-ingress-controller-0.1.0-rc2-src.tar.gz
> > > ```
> > >
> > > 3. Unzip and Check files
> > >
> > > ```sh
> > > $ mkdir -p apisix-ingress-controller && tar zxvf
> > > apache-apisix-ingress-controller-0.1.0-rc2-src.tar.gz
> > > -C ./apisix-ingress-controller && cd apisix-ingress-controller
> > > ```
> > >
> > > 4. Build
> > >
> > > Please refer to
> > >
> > >
> >
> https://github.com/apache/apisix-ingress-controller/blob/v0.1.0/docs/install.md#manual-build
> > >
> > > The vote will keep open at least 72 hours or reaches the necessary
> number
> > > of approved votes.
> > >
> > > Please vote accordingly:
> > >
> > > [ ] +1 Approve
> > > [ ] +0 No Opinion
> > > [ ] -1 Disapprove with your reason
> > >
> > > Thanks!
> > >
> >
> >
> > --
> >
> > *MembPhis*
> > My GitHub: https://github.com/membphis
> > Apache APISIX: https://github.com/apache/apisix
> >
>
