> > > > -#if APR_HAVE_CORKABLE_TCP > > > > +#if APR_HAVE_CORKABLE_TCP && !defined(__FreeBSD__) > > > > > > > > /* TCP_CORK & TCP_NOPUSH keep us from sending partial frames when we > > > > * shouldn't. They are however, mutually exclusive with TCP_NODELAY > > > > > > I don't understand this. Why don't we just /not/ define > > > APR_HAVE_CORKABLE_TCP on the FreeBSD boxes? (in the ./configure script) > > > That > > > seems more appropriate than adding platform-specific checks into the code. > > > > Both methods do the same thing. I decided to put the checks in the code, > > because I am assuming that at some point we will actually add support for > > os_cork and os_uncork to the code. > > If they do the same thing, would it not be better to put the check > for __FreeBSD__ in the autoconf macro that sets APR_HAVE_CORKABLE_TCP? > > The whole point of using #ifdef HAVE_XXX style macros is to > avoid checks exactly like defined(__FreeBSD__). You want > feature tests in your code, not OS tests.
This was answered in the message that you replied to. I explained my exact reasoning, and why I didn't want to do it in the autoconf file. Ryan _______________________________________________________________________________ Ryan Bloom [EMAIL PROTECTED] 406 29th St. San Francisco, CA 94131 -------------------------------------------------------------------------------
