> That allows the snippet above to collapse to this:
> 
>     APR_BRIGADE_INSERT_HEAD(bb, apr_bucket_file_create(fd, 0,
> r->finfo.size));
>     APR_BRIGADE_INSERT_TAIL(bb, apr_bucket_eos_create());
> 
> AFAICT, the cost is minimal, and the code is much cleaner looking.  Since
> these sequences of bucket creation/insertion can be arbitrarily long, this
> is a Good Thing IMHO.  Thoughts?

++1.  If you provide a full patch, I will commit it immediately.

Ryan


Reply via email to