Victor, ap_config.h says:
* @tip extern AP_DECLARE_DATA type apr_variable; syntax is required for * declarations within headers to properly import the variable. and apr.h says: * @tip extern APR_DECLARE_DATA type apr_variable; syntax is required for * declarations within headers to properly import the variable. Given that we have documentation to the *contrary* to what you just checked in, then what is the proper resolution? They cannot both be right. When you say "for detection's sake", are you talking about our tools for detecting declarations? Then the tools need to be corrected. Honestly, I'm starting to get awfully tweaky about your checkins. It seems that just about every checkin needs some kind of review or commentary on it. Or in other cases, you make another checkin just a short amount of time later to alter what you had just done. So.... Your ordering changes for APR_DECLARE_DATA needs more work. It is contrary to the doc in the headers. You need to back it out, or you need to update the doc in the headers. But, of course, before you can update the headers, you need to resolve why that order was specified in the first place, what impact changing it will be, etc. I recall a series of checkins a while back to ensure that we had all the orders correct for modules throughout the system. Now, you're working contrary to that, and that raise a red flag. Cheers, -g On Sat, Jun 09, 2001 at 04:19:57AM -0000, [EMAIL PROTECTED] wrote: > orlikowski 01/06/08 21:19:57 > > Modified: include apr_time.h > include apr_hooks.h > Log: > Put some declarations in the right order, for detection's sake. > > Revision Changes Path > 1.37 +2 -2 apr/include/apr_time.h > > Index: apr_time.h > =================================================================== > RCS file: /home/cvs/apr/include/apr_time.h,v > retrieving revision 1.36 > retrieving revision 1.37 > diff -u -r1.36 -r1.37 > --- apr_time.h 2001/04/12 16:50:49 1.36 > +++ apr_time.h 2001/06/09 04:19:54 1.37 > @@ -67,8 +67,8 @@ > * @package APR Time library > */ > > -extern APR_DECLARE_DATA const char apr_month_snames[12][4]; > -extern APR_DECLARE_DATA const char apr_day_snames[7][4]; > +APR_DECLARE_DATA extern const char apr_month_snames[12][4]; > +APR_DECLARE_DATA extern char apr_day_snames[7][4]; > > > /* number of microseconds since 00:00:00 january 1, 1970 UTC */ > > > > 1.40 +3 -3 apr-util/include/apr_hooks.h > > Index: apr_hooks.h > =================================================================== > RCS file: /home/cvs/apr-util/include/apr_hooks.h,v > retrieving revision 1.39 > retrieving revision 1.40 > diff -u -r1.39 -r1.40 > --- apr_hooks.h 2001/05/15 04:23:39 1.39 > +++ apr_hooks.h 2001/06/09 04:19:56 1.40 > @@ -229,20 +229,20 @@ > * The global pool used to allocate any memory needed by the hooks. > * @defvar apr_pool_t *apr_global_hook_pool > */ > -extern APU_DECLARE_DATA apr_pool_t *apr_global_hook_pool; > +APU_DECLARE_DATA extern apr_pool_t *apr_global_hook_pool; > > /** > * A global variable to determine if debugging information about the > * hooks functions should be printed > * @defvar apr_pool_t *apr_debug_module_hooks > */ > -extern APU_DECLARE_DATA int apr_debug_module_hooks; > +APU_DECLARE_DATA extern int apr_debug_module_hooks; > > /** > * The name of the module that is currently registering a function > * @defvar apr_pool_t *apr_current_hooking_module > */ > -extern APU_DECLARE_DATA const char *apr_current_hooking_module; > +APU_DECLARE_DATA extern const char *apr_current_hooking_module; > > /** > * Register a hook function to be sorted > > > -- Greg Stein, http://www.lyra.org/
