Ryan Bloom <[EMAIL PROTECTED]> writes:
> File open shouldn't handle the temp file stuff. That is overloading
> apr_file_open
> too much. It already has too many different modes of operation. We should
> have a separate API that creates a temp file. That API should call
> apr_file_opn
> and apr_mkstemp under the covers.
not exactly... perhaps apr_file_open() and apr_file_create_temp()*
should call the common code under the covers for certain mundane
details
a concise set of code (e.g., apr_mkstemp()) needs to be in charge of
the filename generation and the open(), or security is hard to maintain
it should be simple for apr_file_open() on Unix to substitute the
open() call with an apr_mkstemp() call when appropriate, but a
separate API is fine... there will just be some shuffling around of
code from apr_file_open() to one or two utility routines called from
both apr_file_open() and apr_file_create_temp()*
*just a silly name I made up for the purposes of this post; not a real
suggestion :)
--
Jeff Trawick | [EMAIL PROTECTED] | PGP public key at web site:
http://www.geocities.com/SiliconValley/Park/9289/
Born in Roswell... married an alien...
