On Monday 24 September 2001 11:27 am, 'Justin Erenkrantz' wrote: > On Mon, Sep 24, 2001 at 01:33:07PM -0400, MATHIHALLI,MADHUSUDAN > (HP-Cupertino,ex1) wrote: > > Thanks for the review.. I'll submit the patch today (positive). As > > regards the 2nd file - I'm not sure if there are any APR specific naming > > conventions.. I've split the shmem.c into 3 files > > 1. shmem.c - containing the unix implementation of shared memory > > 2. shmem_lib.c - containing the list manipulation logic > > 3. shmem.h - containing the data structures.. > > I'd rather not do that if at all possible. Let's keep it at one file > for now. (I'll follow whatever Ryan says though if he has a > preference...) > > If at some later point we decide that we should split it we can. > You typically want to split the files when something else may use > these functions (i.e. they are exported) - that isn't the case here. > For now, the helper functions should be declared as static (which > means they need to be in the same compilation unit) - otherwise we > get into namespace issues (i.e. must be prefixed by apr_). -- justin
I want those functions exported, because they can be used by any platform to create the shared memory list. This makes porting to Windows much easier than it will be if I have to re-write all of the list functions. Ryan ______________________________________________________________ Ryan Bloom [EMAIL PROTECTED] Covalent Technologies [EMAIL PROTECTED] --------------------------------------------------------------
