Really ment to send this here.
----- Original Message ----- From: "William A. Rowe, Jr." <[EMAIL PROTECTED]> To: <[email protected]> Sent: Monday, December 31, 2001 5:48 PM Subject: Re: cvs commit: apr/misc/win32 rand.c > From: "Roy T. Fielding" <[EMAIL PROTECTED]> > Sent: Monday, December 31, 2001 4:16 PM > > > > On Sun, Dec 30, 2001 at 07:50:47PM -0000, [EMAIL PROTECTED] wrote: > > > --- rand.c 29 Dec 2001 03:33:49 -0000 1.11 > > > +++ rand.c 30 Dec 2001 19:50:46 -0000 1.12 > > > @@ -62,8 +62,10 @@ > > > HCRYPTPROV hProv; > > > apr_status_t res = APR_SUCCESS; > > > > > > + /* 0x40 bit = CRYPT_SILENT, only introduced in more recent PSDKs > > > + */ > > > if (!CryptAcquireContext(&hProv, NULL, NULL, PROV_RSA_FULL, > > > - CRYPT_VERIFYCONTEXT | CRYPT_SILENT)) { > > > + CRYPT_VERIFYCONTEXT | 0x40)) { > > > > Eh? Why didn't you do > > > > #ifndef CRYPT_SILENT > > #define CRYPT_SILENT 0x40 > > #endif > > Suppose that would work just as well... > > I'm actually considering > > #ifndef CRYPT_SILENT > #define CRYPT_SILENT 0x40 > #elif CRYPT_SILENT != 0x40 > #error "The CRYPT_SILENT define has changed... please correct and rebuild" > #endif > > and moving the whole lot of them [several others used in file_io] into a > winfixsdk.h hiding over in apr/misc/win32/. Comments? > > Bill > > >
