Ok... Now that I've followed this conversation a while... I'm entirely -1 on any function changing arguments based on dev/release builds.
That means we can have the file/line arg of NULL if we simply _don't care_, so we don't waste const string heap, but there will be a char* argument always, or never. Pushing an extra NULL in a release build to the infrequently called apr_pool_create is trivial. And painless. Bill ----- Original Message ----- From: "Sander Striker" <[EMAIL PROTECTED]> To: <[email protected]> Sent: Sunday, January 13, 2002 12:36 PM Subject: Passing file/line ALL the time WAS: RE: [PATCH] Default tagging of pools in debug mode [2] > > From: Ian Holsman [mailto:[EMAIL PROTECTED] > > Subject: Re: [PATCH] Default tagging of pools in debug mode [2] > > > > Stupid Question Time: > > is there a problem just enabling file/line passing to this ALL the time? > > I mean.. it's just a extra parameter on the stack. > > > > this would make it MUCH easier to enable/disable debugging. > > Although it would make things easier to enable debugging, for > normal operation of an apr using application it is not needed. > > I don't feel the current hurdle one has to take to do memory > debugging is too high. > > I'm -1 on doing file/line passing by default. It is a debugging > tool/feature and it should stay that. > > Sander > >
