From: <[EMAIL PROTECTED]> Sent: Monday, January 28, 2002 3:52 PM
> > From: "William A. Rowe, Jr." <[EMAIL PROTECTED]> > > Date: Wed, 16 Jan 2002 14:14:21 -0600 > > > > > On Tue, Jan 15, 2002 at 05:39:59PM -0800, John Sterling wrote: > > > > > > > > Long ago (maybe 3 years ago?) Manoj generated a patch for 1.3 which > > > > added > > > > some widely used formats which were not implemented in the libc > > > > implementation of strftime on win32. > > > > > > > > Ideally we would continue to implement formats as necessary (or should > > > > we spend some > > > > time implementing them all?). > > > > +1 here as well, and since strftime() isn't even consistent on all Un*x > > platforms, > > we would be best off doing this; > > > > 1. Define our set of supported strftime() escapes. > > > > 2. Create a bit of autoconf magic to format a string, repleat with all > > our supported escapes, and compare to our 'expected' result. > > > > 3. If so, HAVE_COMPLETE_STRFTIME and use the clib's implemention... > > > > 4. ... otherwise use the apr implementation. > > > > I'll commit John's code, but want to see us start testing across the board > > for > > our agreed-upon format tokens [however we define them]. > > can we get this patch committed? just checking in :) As I suggested I would, I've committed the patch. Now if anyone cares, the win32 fn should really move to the unix/time directory as a global (without the win32 name), it's formats extended to everthing that -APR- insists will be portable, and a bit of autoconf magic authored. But this patch is sufficient for now. I don't have the energy to invest in the project I propose above, so if noone has the itch, it will languish a while :) Bill
