Ryan Bloom wrote:
-----Original Message-----
From: Justin Erenkrantz [mailto:[EMAIL PROTECTED]
Sent: Wednesday, February 06, 2002 8:59 AM
To: Sander Striker
Cc: [email protected]
Subject: Re: [PATCH] Free memory over a certain threshold back to the
system

On Wed, Feb 06, 2002 at 01:24:36PM +0100, Sander Striker wrote:

Hi,

The 'high free' patch.  I'm not sure we want this.
It may hide pools abuse problems.

Yeah, I agree we don't really want this.  If we run out of memory
with the normal pools, it means that the lifetimes are most likely
incorrect.

But, perhaps this could be a #define with a debug option?  -- justin


We definitely don't want this IMHO. If the pools are filling up, then either pools are the incorrect model for your app, or they aren't being cleared often enough. I would much rather not have this as an option at all, because that just encourages people to use it. :-)

Ryan

that's not the case at all.
it will stop people using pool (and probably the APR) for application which have a large variance in their memory requirements over time.
by not having this patch in your forcing the application to always grow
over time, or at the least always stay at it's high water mark.


Take for instance a message queue. normally the message queue is running
at 2-3 messages in the queue..something borks up on the GET side causing the messages to pile up to 2k. the GET side then is fixed and empties the queue..
if we had the himem-free patch APR would be a great in here.. without it
the size of the queue will allways be 2k instead of shrinking to 2-3.


so..
i'm +1 on this patch









Reply via email to