Just a word to the wise, there are apps out there that rely on this behavior. Apache is one of them, so if you modify this, please double check Apache at the same time.
Ryan ---------------------------------------------- Ryan Bloom [EMAIL PROTECTED] 645 Howard St. [EMAIL PROTECTED] San Francisco, CA > -----Original Message----- > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] > 166.nc.rr.com] On Behalf Of Jeff Trawick > Sent: Wednesday, March 13, 2002 6:55 AM > To: Aaron M. Folmsbee > Cc: [email protected] > Subject: Re: apr_file_gets return code > > "Aaron M. Folmsbee" <[EMAIL PROTECTED]> writes: > > > apr_file_gets returns APR_EOF if it encounters an eof condition ( or any > > error condition...) while there is still room left in the read buffer. > > This means that APR_EOF is returned if you read the last line in a file > > with a buffer larger then the last line. I would submit that the correct > > behaviour is to return success if anything is read before encountering > > the eof. > > I think I agree with your comment about the proper behavior: It should > return APR_SUCCESS if it read any bytes into the caller's buffer. > > What OS did you encounter the problem on? > > Was there a '\n' at the end of the file? > > Do you have a patch? > > -- > Jeff Trawick | [EMAIL PROTECTED] > Born in Roswell... married an alien...
