Re: [PATCH] lower CPU for sending data via sendfile()

[Brian Pane]

Jeff Trawick wrote:

Brian Pane <[EMAIL PROTECTED]> writes:

Jeff Trawick wrote:

+    if (sock->netmask & APR_INCOMPLETE_WRITE) {
+        sock->netmask &= ~APR_INCOMPLETE_WRITE;
+        goto do_select;
+    }
+
   do {
       rv = sendfile(sock->socketdes,        /* socket */
              file->filedes, /* open file descriptor of the file to be sent */

Without this patch, what was happening?  Did you get EAGAIN on the
sendfile call?

yeah, a wasted (EAGAIN) sendfile call for every good sendfile call

Got it...  I'll add the same fix for the writev case tomorrow
if nobody else gets to it first.

--Brian