> From: Karl Fogel [mailto:[EMAIL PROTECTED] > > Justin Erenkrantz <[EMAIL PROTECTED]> writes: > > In APR calls, if EINVAL is produced, it should use APR_EINVAL. > > > > And, for checking for error, the caller should use > > APR_STATUS_IS_EINVAL(s). -- justin > > Well, this is *us* generating the EINVAL by fiat, not getting it from > some lower-down system call. > > Maybe we should still go with APR_EINVAL, on the principle of least > surprise, though. I'm not sure; trusting people with more APR > experience to know a good answer here.
Just for completeness. We should be returning APR_EINVAL, because that is the safe code. However, on all platforms that implement EINVAL, EINVAL and APR_EINVAL are equivalent. And, I can't think of any platforms that don't define EINVAL. Ryan
