Below are the updated patches I mentioned last night. They are the same as
previously submitted
(http://marc.theaimsgroup.com/?l=apr-dev&m=102721946317193&w=2,
http://marc.theaimsgroup.com/?l=apache-httpd-dev&m=102721825716797&w=2) but ported to HEAD.
Thanks for the patches!
Its not clear to me which poll API should be used when. Apache uses the deprecated API. Some thoughts on the subject should probably be put in poll.h and Apache updated.
I'm as stumped as you. FWIW, both should work. It makes no difference
right now, but will when Brian implements /dev/poll [or /dev/epoll] and I attack
WSAAsyncSelect, both of which require the accessor-based api to be easily
reusable [performantly] from poll to poll.
Somewhere along the way in the recent wave of commits (rev 1.14?), a change was committed to apr_poll() that presumes that the apr_pollfd_t struct is packed. I believe this was inadvertent, but its not clear because (the deprecated) socket_add() and friends don't handle either packed or sparse correctly. These problems are corrected in the patch below (sparse support).
I applied part of your fixes [resolving the next issue.] That's the problem with
submitting a patch of more than one issue... the net error issue was easy
for me to attack at the moment.
NOTE: The use of APR_FROM_OS_ERROR() should probably instead use apr_get_netos_error(), but that doesn't look defined for platforms other than WIN and NETWARE.
The lack of implementations was the real bug, this is committed.
Don't we have h_errno issues on some flavors of unix?
Bill
