Mladen Turk wrote: > > >>-----Original Message----- >>From: Branko Cibej [mailto:[EMAIL PROTECTED] >>Sent: 11. ožujak 2003 1:40 >>To: [EMAIL PROTECTED] >>Cc: dev@apr.apache.org >>Subject: Re: [PATCH] apr-iconv: enable prelinked modules >> >> >> >>Mladen, most of this patch are whitespace-only changes. That >>makes it very hard to see the real text changes. Can you >>please fix that and repost? I can't review this if I have to >>keep track of which parts of the patch are important and >>which parts are just noise. >> >>Thanks. >> >> > >Could you first remove the tabs from apr-iconv. > Huh? What do tabs in the original code have to do with your whitespace-only changes? If your patch doesn't chang it, it shouldn't change by itself.
>Some said 'there should be only spaces' ;). > Yes, that's true. We imported the apr-iconv code from elsewhere, and didn't change either tabs or indentation. But we don't *want* to do that, IMHO, because if we do, diffs against old versions would be useless. So please, just insert the pertinent parts of your patch into a fresh copy of apr-iconv, taking care to leave other whitespace alone. If I can do that, so can you. >I'll repost then. > >MT. > > > -- Brane Čibej <[EMAIL PROTECTED]> http://www.xbc.nu/brane/
