On Sun, Aug 03, 2003 at 01:17:15AM +0200, Andr� Malo wrote: > Well, I've started with a patch (attached). It works fine for me, but I'm not > sure with the naming at all. Any comments?
I understand the need for a strcasecmp replacement, but are the strcmp/!strcmp replacements just for consistency? On some platforms strcmp is an optimised asm inline so unless there's a good reason to tempt people away from strcmp I'd leave apr_streq/strneq out. Adding the global arrays to apr_lib.h adds 512 bytes to every object file which includes that header, not sure that is a good idea, could result in noticeably bigger executables. Regards, joe
