On Tue, Jan 27, 2004 at 07:33:25PM -0800, Ben Reser wrote: > On Tue, Jan 27, 2004 at 10:32:20AM -0500, Greg Hudson wrote: > > There is a new idea afloat, incidentally: rather than fix apr_off_t at > > 64 bits, fix apr_off_t at the size off_t has at configuration time. > > (There appears to be no off32_t, so that would have to be apr_int32_t on > > most 32-bit platforms.) That doesn't get large-file support, but it > > does make apr_off_t independent of _FILE_OFFSET_BITS, and it doesn't > > cause an ABI change. > > Attached is an implementation of this idea. The idea was originally > suggested by Tobias Ringström in: > http://marc.theaimsgroup.com/?l=subversion-dev&m=107490548803069&w=2 > > This also removes some cruft that appears to have been added because > sizeof(int) == sizeof(long) on some platforms. Which this patch happily > avoids altogether for us. :)
That looks great: I'll commit your patch to the 0.9 branch unless there are any objections. Thanks a lot for working on this issue. joe
