[resend in case it gets through quicker]
On Tue, Jun 22, 2004 at 10:42:23AM -0000, [EMAIL PROTECTED] wrote:
--- apr_xml.c 14 Jun 2004 15:13:14 -0000 1.30
+++ apr_xml.c 22 Jun 2004 10:42:23 -0000 1.31
@@ -30,17 +30,23 @@
#include "expat.h"
#endif
+#include "ascii.h"
+
#define DEBUG_CR "\r\n"
ascii.h is an internal expat header, this broke the Unix build with an external expat library.
Ok. I will #define ASCII_* instead including the ascii.h.
Why take a convset if this can only convert to EBCDIC? You know that the tree is in UTF-8 so there is no other variable for the caller to control.
The convset I have used is ap_hdrs_from_ascii. (APR_DEFAULT_CHARSET, "ISO8859-1") that is fixed.
Passing the convset allows to convert to another charset.
Why does the DOM tree need to be converted into the local charset in-place anyway?
I am running mod_dav on an EBCDIC mainframe. That is more easy to convert the DOM tree in-place than to change mod_dav everywhere.
#if APR_CHARSET_EBCDIC
/**
* Convert parsed tree in EBCDIC * @param p The pool to allocate out of
* @param pdoc The apr_xml_doc to convert.
* @param xlate The translation handle to use.
* @return Any errors found during conversion.
*/
APU_DECLARE(apr_status_t) apr_xml_parser_convert_doc(apr_pool_t *p,
apr_xml_doc *pdoc,
apr_xlate_t *convset);
#endif
