Joe Orton wrote:
w.r.t. common code, depends what the changes are; if there are places
where an int is used to store the difference between pointers, it's
probably a good and safe change to make that an apr_ssize_t instead.

Yes, there are a few of those, they are the easy ones to fix :)

w.r.t. warnings: yes, gcc is just less picky. But Win64 has a 32-bit
long, right?

That's correct, but that actually contributes to a fairly low % of warnings

+ rv = collapse_iovec((char**) &ptfb->Tail, (apr_size_t *)&ptfb->TailLength,

if that's casting (int *) to (size_t *) that looks dangerous.

Will take another look at that. I'm offline for the next 3 days but hope to pick it up again next Monday.

Thanks
Allan



Reply via email to