On Tue, Nov 16, 2004 at 01:30:00PM +0000, Julian Foad wrote: > Branko Äibej wrote: > >If the #if was an exception WRT the BEOS symbol, then > >your change is fine; but you should say so (perhaps you did in another > >post and I missed it; sorry). > > I did say so when I first posted the patch a few days ago, but I should say > so in the log message. The patch is re-attached with an improved log > message.
The fact that -Wundef exposed bugs like apr_signal_block() being a noop seems like sufficient justification to make the source -Wundef clean to avoid future screwups, I agree with this. But any chance you could fix them all rather than picking them off one at at time? file_io/unix/pipe.c:27:5: warning: "BEOS" is not defined file_io/unix/pipe.c:37:6: warning: "BEOS_BLOCKING" is not defined file_io/unix/pipe.c:73:6: warning: "BEOS_BLOCKING" is not defined file_io/unix/readwrite.c:23:6: warning: "BEOS_R5" is not defined support/unix/waitio.c:24:6: warning: "BEOS_R5" is not defined Regards, joe
