Can I have a second set of eyes for a reality check before I backport this compile-time cleanup?
It looks fine to me, if you think it is appropriate to back-port such a clean-up.
The log message is rather difficult to understand.
- Julian
[...]
[...]Log:
Clean up 4 extranious emits. Because of the modulo operator, these becomes safe casts to unsigned.
- usedspace = (context->bitcount >> 3) % SHA256_BLOCK_LENGTH;
+ usedspace = (unsigned int)((context->bitcount >> 3) + % SHA256_BLOCK_LENGTH);
[...]
