Given that the lack of hostinfo decoding of apr_uri_parse() may need to be
preserved for compatibility reasons, its behavior should be documented.


--- include/apr_uri.h   (revision 189835)
+++ include/apr_uri.h   (working copy)
@@ -148,9 +148,10 @@
                                     unsigned flags);
 
 /**
- * Parse a given URI, fill in all supplied fields of a apr_uri_t
- * structure. This eliminates the necessity of extracting host, port,
- * path, query info repeatedly in the modules.
+ * Parse a given URI, and fill in all supplied fields of a apr_uri_t
+ * structure (@c hostinfo is not decoded).  This eliminates the
+ * necessity of extracting host, port, path, query info repeatedly in
+ * modules.
  * @param p The pool to allocate out of
  * @param uri The uri to parse
  * @param uptr The apr_uri_t to fill out

--- Begin Message ---
On Sat, 2005-10-01 at 12:09 -0500, [EMAIL PROTECTED] wrote:
> * subversion/libsvn_ra_svn/client.c (find_tunnel_agent): URI-decode hostinfo
>     portion of URL before using it to construct tunnel agent argv.

apr_uri_parse() doesn't do this for us?  It seemed intuitive to me that
it would.  (And perhaps fundamentally broken that it doesn't.)

It'd be nice if APR would document these things.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

--- End Message ---

Reply via email to