Joe Orton wrote: > On Thu, Oct 27, 2005 at 11:22:42PM -0700, Paul Querna wrote: >> William A. Rowe, Jr. wrote: >>> [EMAIL PROTECTED] wrote: >>>> Author: pquerna >>>> Date: Thu Oct 27 21:23:01 2005 >>>> New Revision: 329089 >>>> >>>> URL: http://svn.apache.org/viewcvs?rev=329089&view=rev >>>> Log: >>>> Import apr_memcache trunk to APR-Util. >>>> >>>> Still TODO: >>>> - Move CRC32 to a separate public function/API. >>>> - Create a multi-get interface. >>>> - Make locking and connection pooling optional. >>> For the moment, -1, please revert and begin an apr-memcache sandbox >>> because... >>> >>> * it makes trunk/ unstable, preventing us from moving to 1.3 >> Then branch 1.3 and revert in the branch. Trunk should always be safe >> to commit to, IMHO. > > Agreed. Some review: > > - apr_memcache_hash's data_len argument, apr_memcache_conn_t.blen , > storage_cmd_write's *_size arguments are all apr_uint32_t and look like > they should be apr_size_t, any reason why that is?
Ah, now I remember why. The memcached protocol states that these data lengths are all unsigned 32bit ints. So, they can never hold values larger, or the server will not understand. -Paul
