Garrett Rooney wrote:
The fix is to use IsValidSid to confirm the validity of the uid/gid before we try to call LookupAccountSid.
I'd disagree. The test tried to force a hardcode platform specific value at apr_uid_get etc... that's invalid and should crash the users' code. We have a general principal in apr that faulty code produces crashes, while faulty data produces errors. I'd disagree that the data was faulty. What uid/gid were they trying to test? Should we have some static helpers to get the root / everyone sorts of ID's on a platform-by-platform basis?
The one thing I'm really not sure of is what should be done on non-NT systems. The MSDN docs say that IsValidSid didn't show up until NT workstation 3.1.
Rule of thumb; Win95 is bare minimum baseline, and we aren't really even trying to support anything pre-WinNT (although if folks continue to offer patches for 9x series platforms I guess they will always be welcomed while we can apply them without hurting a more sophisticated implementation.)
