Looks good, +1 to commit to branches 0.9, 1.2 and trunk.
I see --with-gdbm=yes already does some sane looking for an obvious install
path of gdmb.h etc, so the change should be mostly painless. An obvious note
in CHANGES would be useful here for users who wish to continue configuring
against gdbm.
Bill
Garrett Rooney wrote:
On 2/3/06, William A. Rowe, Jr. <[EMAIL PROTECTED]> wrote:
It's a showstopper if we violate licensing terms, period. In fact a case
could be made to take down www.apache.org/dist/apr/ today. But I think that
the better solution is to immediately and agressively address this flagrent
stealth license now, and release a version that users and distributors clearly
are aware of any licensing impacts of their --with-xxx decisions.
FWIW, here's a patch (to trunk) that handles the GDBM side of things,
since it's like a 2 line change. Seems to work just fine here. I
didn't do anything about BDB, since the BDB part of the configure
scripts scare me...
-garrett
------------------------------------------------------------------------
Index: build/dbm.m4
===================================================================
--- build/dbm.m4 (revision 374803)
+++ build/dbm.m4 (working copy)
@@ -607,6 +607,7 @@
requested=default
])
+ dnl We don't pull in GDBM unless the user asks for it, since it's GPL
AC_ARG_WITH([gdbm], [
--with-gdbm=DIR specify GDBM location
], [
@@ -626,9 +627,6 @@
APR_ADDTO(APRUTIL_INCLUDES, [-I$withval/include])
fi
fi
- ], [
- apu_have_gdbm=0
- AC_CHECK_HEADER(gdbm.h, AC_CHECK_LIB(gdbm, gdbm_open, [apu_have_gdbm=1]))
])
AC_ARG_WITH([ndbm], [
