I'm with Garrett, this looks reasonable enough, but I just don't know enough about win32 to say that on a visual inspection. I think this needs to bake for a while.
Ryan On 3/25/06, William A. Rowe, Jr. <[EMAIL PROTECTED]> wrote: > Garrett Rooney wrote: > > > >>I've refactored the read_with_timeout() code to account for observations > >>about both WAIT_ABANDONED and the short race between ReadFile, WaitFor... > >>CancelIo and GetCompletion. > > > > Considering the lack of regression tests to catch problems with this > > code, I think it's rather premature to stick it in 0.9.11. > > Thank you for taking the time to review these changes Garrett. Although > we have a few reporters keenly interested in such things, they apparently > aren't watching svn commits closely enough to give us confidence that this > code is golden. I'd really like some feedback from original contributors > to file_io/win32/readwrite.c but know that people are busy. > > We did identify the issues with m4 caches and xml/expat (wish those had > slipped into 1.2.x sigh) and the aprutil cache, so those fixes will go in > with 0.9.11 and we'll call it a day. Another couple weeks and we can push > all these changes to readwrite etc into a release, maybe get some folks > to try out snapshots if it causes them grief. > > Bill > -- Ryan Bloom [EMAIL PROTECTED] [EMAIL PROTECTED] [EMAIL PROTECTED]
