Joe: > Thanks Chris. For stuff like this feel free to avoid the overhead of > bugzilla; it's not a bug in the code which needs tracking as such, and > it's easier to review patches in mail.
Okey doke! > I committed the testprocmutex.c patch with a few changes: > > - remove unnecessary whitespace changes > - use a function paramater rather than a global variable Thanks, sounds great -- do you in general prefer to avoid whitespace changes across the board, or is there a policy for tackling such things? I'm only thinking of APR and httpd, really, but I stumble upon odd indents and such from time to time and never know how to handle them. Maybe formatting-only patches that don't alter functionality? Dunno. > haven't looked at the other patch. Yeah, it's non-functional because that whole global mutex test is effectively commented out, so it's definitely non-critical. Chris. -- GPG Key ID: 366A375B GPG Key Fingerprint: 485E 5041 17E1 E2BB C263 E4DE C8E3 FA36 366A 375B
