Bojan Smojver wrote:
Here is a quick patch that should get rid of the "commit twice" code. I also removed explicit rollback, as it is not required (SQLite3 rolls back by itself when things aren't good).Note also that the default return code was changed to -1 in this patch. It is normally an error to end a transaction that that was never started, so this change is trying to emulate that behaviour.I'll test this and wait for the feedback before I commit.
Looks good to me
