On Wed, Jun 07, 2006 at 02:04:44AM -0000, [EMAIL PROTECTED] wrote: > Author: bojan > Date: Tue Jun 6 19:04:43 2006 > New Revision: 412252 > > URL: http://svn.apache.org/viewvc?rev=412252&view=rev > Log: > Properly free results table. > > Modified: > apr/apr-util/trunk/dbd/apr_dbd_sqlite2.c > > Modified: apr/apr-util/trunk/dbd/apr_dbd_sqlite2.c > URL: > http://svn.apache.org/viewvc/apr/apr-util/trunk/dbd/apr_dbd_sqlite2.c?rev=412252&r1=412251&r2=412252&view=diff > ============================================================================== > --- apr/apr-util/trunk/dbd/apr_dbd_sqlite2.c (original) > +++ apr/apr-util/trunk/dbd/apr_dbd_sqlite2.c Tue Jun 6 19:04:43 2006 > @@ -97,7 +97,7 @@ > (*results)->random = seek; > > if (tuples > 0) > - apr_pool_cleanup_register(pool, *result, (void *) free, > + apr_pool_cleanup_register(pool, result, (void *) > sqlite_free_table, > apr_pool_cleanup_null);
This is really still a long way from "properly" - both the old and new code has undefined behaviour because of the function cast. joe
