I'd like to commit this patch which adds an APR_ESSL error to APR. It's only use will be in the ssl code now in apr-util. Is this the right place for it?

Index: ../apr/include/apr_errno.h
===================================================================
--- ../apr/include/apr_errno.h  (revision 413480)
+++ ../apr/include/apr_errno.h  (working copy)
@@ -271,6 +271,8 @@
 #define APR_EPROC_UNKNOWN  (APR_OS_START_ERROR + 27)
 /** @see APR_STATUS_IS_ENOTENOUGHENTROPY */
 #define APR_ENOTENOUGHENTROPY (APR_OS_START_ERROR + 28)
+/** @see APR_STATUS_IS_ESSL */
+#define APR_ESSL (APR_OS_START_ERROR + 29)
 /** @} */

 /**
@@ -362,6 +364,12 @@
 /** APR could not gather enough entropy to continue. */
 #define APR_STATUS_IS_ENOTENOUGHENTROPY(s) ((s) == APR_ENOTENOUGHENTROPY)

+/** An error has occurred in the SSL code.
+ * apr_ssl_socket_error() may be called to get a numeric error code
+ * apr_ssl_socket_error_string() may be called for an error description
+ */
+#define APR_STATUS_IS_ESSL(s)  ((s) == APR_ESSL)
+
 /** @} */

 /**

Oh, and this is a small typo (I think) that should be committed :-)

@@ -575,7 +583,7 @@
 #define APR_EACCES         (APR_OS_START_CANONERR + 1)
 #endif

-/** @see APR_STATUS_IS_EXIST */
+/** @see APR_STATUS_IS_EEXIST */
 #ifdef EEXIST
 #define APR_EEXIST EEXIST
 #else

Reply via email to