Damnit, you really want more case-canonical flaws in httpd?
I don't give a shit if it's force-lower or force-upper. It so happens that 90% of the time, the NT Kernel represents drive letters in upper case. But it's neither here nor there, revert this. Oh - btw - nice job Justin and Paul on the MinGW effort! Bill [EMAIL PROTECTED] wrote:
Author: pquerna Date: Sat Jul 15 00:16:32 2006 New Revision: 422157 URL: http://svn.apache.org/viewvc?rev=422157&view=rev Log: apr_filepath_root: Remove the force upper-casing of the Drive letter on Win32. This was causing the test failure on testnames line 219. All evidence points to that the comment above the upper case switch is invalid, since everything passes after removing it. Modified: apr/apr/trunk/file_io/win32/filepath.c Modified: apr/apr/trunk/file_io/win32/filepath.c URL: http://svn.apache.org/viewvc/apr/apr/trunk/file_io/win32/filepath.c?rev=422157&r1=422156&r2=422157&view=diff ============================================================================== --- apr/apr/trunk/file_io/win32/filepath.c (original) +++ apr/apr/trunk/file_io/win32/filepath.c Sat Jul 15 00:16:32 2006 @@ -283,10 +283,6 @@ { apr_status_t rv; /* Validate that D:\ drive exists, test must be rooted - * Note that posix/win32 insists a drive letter is upper case, - * so who are we to argue with a 'feature'. - * It is a safe fold, since only A-Z is legal, and has no - * side effects of legal mis-mapped non-us-ascii codes. */ newpath = apr_palloc(p, 4); newpath[0] = testpath[0]; @@ -294,7 +290,6 @@ newpath[2] = seperator[0]; newpath[3] = '\0'; if (flags & APR_FILEPATH_TRUENAME) { - newpath[0] = apr_toupper(newpath[0]); rv = filepath_root_test(newpath, p); if (rv) return rv; .
