Joe Orton wrote:

2) it's a really bad implementation. You can do the same thing portably by doing a poll() and a recv(,MSG_PEEK) AFAICT. There is no need to muck about with ioctls, and it can be done already without adding anything to APR.


recv(, MSG_PEEK) is not portable, so its not APR only anyhow.
Further more the poll resolution is millisecond.


2. b) using select() like that will SIGSEGV on Unix for an fd > FD_SETSIZE. There is no excuse to at least not use apr_poll()


Hmm. select(1, ...) can probably be used instead select((int)sock + 1, ...)

Regards,
Mladen.

Reply via email to