[PATCH] we need to init _unknown?

[William A. Rowe, Jr.]

William A. Rowe, Jr. wrote:
> 
> It also appears that sockets.c in MANY cases just fails to initialize
> (local|remote)_interface_unknown, unless I'm imagining things.


Am I blinking insane or was this completely broken?


Index: network_io/win32/sockets.c
===================================================================
--- network_io/win32/sockets.c	(revision 478602)
+++ network_io/win32/sockets.c	(working copy)
@@ -59,9 +59,11 @@
     (*new)->local_addr = (apr_sockaddr_t *)apr_pcalloc((*new)->pool,
                                                        sizeof(apr_sockaddr_t));
     (*new)->local_addr->pool = p;
+    (*new)->local_addr_unknown = 1;
     (*new)->remote_addr = (apr_sockaddr_t *)apr_pcalloc((*new)->pool,
                                                         sizeof(apr_sockaddr_t));
     (*new)->remote_addr->pool = p;
+    (*new)->remote_addr_unknown = 1;
 
     /* Create a pollset with room for one descriptor. */
     /* ### check return codes */
Index: network_io/os2/sockets.c
===================================================================
--- network_io/os2/sockets.c	(revision 478602)
+++ network_io/os2/sockets.c	(working copy)
@@ -62,9 +62,11 @@
     (*new)->local_addr = (apr_sockaddr_t *)apr_pcalloc((*new)->pool,
                                                        sizeof(apr_sockaddr_t));
     (*new)->local_addr->pool = p;
+    (*new)->local_addr_unknown = 1;
     (*new)->remote_addr = (apr_sockaddr_t *)apr_pcalloc((*new)->pool,
                                                         sizeof(apr_sockaddr_t));
     (*new)->remote_addr->pool = p;
+    (*new)->remote_addr_unknown = 1;
 
     /* Create a pollset with room for one descriptor. */
     /* ### check return codes */
Index: network_io/unix/sockets.c
===================================================================
--- network_io/unix/sockets.c	(revision 478602)
+++ network_io/unix/sockets.c	(working copy)
@@ -63,6 +63,7 @@
     (*new)->local_addr = (apr_sockaddr_t *)apr_pcalloc((*new)->pool,
                                                        sizeof(apr_sockaddr_t));
     (*new)->local_addr->pool = p;
+    (*new)->local_addr_unknown = 1;
     (*new)->remote_addr = (apr_sockaddr_t *)apr_pcalloc((*new)->pool,
                                                         sizeof(apr_sockaddr_t));
     (*new)->remote_addr->pool = p;